Messages in this thread | | | From | Ricardo Ribalda Delgado <> | Date | Thu, 23 Apr 2015 09:55:13 +0200 | Subject | Re: [PATCH v3 3/4] base/platform: Continue on insert_resource() error |
| |
Hi Bjorn:
On Wed, Apr 22, 2015 at 6:44 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> Usual style for referencing a commit is "(see 02bbde7849e6 ('Revert "of: > use platform_device_add"'))".
Do you make that reference manually or there is a magic git command for printing it in that style?
>
> Sounds like we should expect to see this message more in the future, after > you change of_platform_device_create_pdata() use platform_device_add(). > You might want to use insert_resource_conflict() here so you can include > information about *why* we failed to claim the resource. And it would be > nice to use %pR for both resources. > .....
>> >> - failed: > > Might be nice to keep a comment here as a clue that the rest of the > function is the failure path.
Will prepare a patch with the changes and resend.
Thanks!
-- Ricardo Ribalda
| |