lkml.org 
[lkml]   [2015]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/8] moduleparam.h: add module_param_config_*() helpers
On Thu, Apr 23, 2015 at 11:45:09AM +0930, Rusty Russell wrote:
> "Luis R. Rodriguez" <mcgrof@do-not-panic.com> writes:
> > From: "Luis R. Rodriguez" <mcgrof@suse.com>
> >
> > This adds a couple of bool module_param_config_*() helpers
> > which are designed to let us easily associate a boolean
> > module parameter with an associated kernel configuration
> > option.
>
> OK.

So this is really the main gain.

> > Folks can use this to avoid what typically would
> > be #ifdef eyesores around module parameter declarations.
>
> Really? So you use this in two patches:
>
> /* see the comment above the definition of WQ_POWER_EFFICIENT */
> -static bool wq_power_efficient = IS_ENABLED(CONFIG_WQ_POWER_EFFICIENT_DEFAULT);
> -module_param_named(power_efficient, wq_power_efficient, bool, 0444);
> +module_param_config_on_off(power_efficient, wq_power_efficient, 0444, CONFIG_WQ_POWER_EFFICIENT_DEFAULT);
>
> And:
>
> static bool sig_enforce = IS_ENABLED(CONFIG_MODULE_SIG_FORCE);
> #ifndef CONFIG_MODULE_SIG_FORCE
> -module_param(sig_enforce, bool_enable_only, 0644);
> +module_param_config_on(sig_enforce, sig_enforce, 0644, CONFIG_MODULE_SIG_FORCE);
> #endif /* !CONFIG_MODULE_SIG_FORCE */
>
> But neither actually, y'know, cleans up any #ifdefs.

OK, sure, its the use of IS_ENABLED() that does that as a first step.

> Simplicity is a major virtue. Readability is a major virtue. Brevity
> is only a minor virtue.

I was not shooting for brevity but instead aiming at the possible
grammatical gain of direct and immediate association between a bool, behaviour
(on_off, or just on), and a config. I don't have a need for the grammatical
association now so will drop this.

Luis


\
 
 \ /
  Last update: 2015-04-23 22:01    [W:0.048 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site