Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [PATCH] elevator: remove unneeded kfree in error path of elevator_alloc | Date | Thu, 23 Apr 2015 10:58:25 -0400 |
| |
Chao Yu <chao2.yu@samsung.com> writes:
> In elevator_alloc, if we fail to allocate memory for storing elevator > queue, our eq pointer must be NULL, we do not need to release it in error > path, so remove it. > > Signed-off-by: Chao Yu <chao2.yu@samsung.com> > --- > block/elevator.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/block/elevator.c b/block/elevator.c > index 59794d0..d146a5e 100644 > --- a/block/elevator.c > +++ b/block/elevator.c > @@ -166,7 +166,6 @@ struct elevator_queue *elevator_alloc(struct request_queue *q, > > return eq; > err: > - kfree(eq); > elevator_put(e); > return NULL; > }
Acked-by: Jeff Moyer <jmoyer@redhat.com>
| |