lkml.org 
[lkml]   [2015]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] tools: perf: consistently use PRIu64 for printing u64 values
    Date
    Building the perf tool for 32-bit ARM results in the following build
    error due to a combination of an incorrect conversion specifier and
    compiling with -Werror:

    builtin-kmem.c: In function ‘print_page_summary’:
    builtin-kmem.c:644:9: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘u64’ [-Werror=format=]
    nr_alloc_freed, (total_alloc_freed_bytes) / 1024);
    ^
    builtin-kmem.c:647:9: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘u64’ [-Werror=format=]
    (total_page_alloc_bytes - total_alloc_freed_bytes) / 1024);
    ^
    cc1: all warnings being treated as errors

    This patch fixes the problem by consistently using PRIu64 for printing
    out u64 values.

    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Joonsoo Kim <js1304@gmail.com>
    Cc: Minchan Kim <minchan@kernel.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: Will Deacon <will.deacon@arm.com>
    ---
    tools/perf/builtin-kmem.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c
    index 63ea01349b6e..a1915b430044 100644
    --- a/tools/perf/builtin-kmem.c
    +++ b/tools/perf/builtin-kmem.c
    @@ -640,9 +640,9 @@ static void print_page_summary(void)
    nr_page_frees, total_page_free_bytes / 1024);
    printf("\n");

    - printf("%-30s: %'16lu [ %'16"PRIu64" KB ]\n", "Total alloc+freed requests",
    + printf("%-30s: %'16"PRIu64" [ %'16"PRIu64" KB ]\n", "Total alloc+freed requests",
    nr_alloc_freed, (total_alloc_freed_bytes) / 1024);
    - printf("%-30s: %'16lu [ %'16"PRIu64" KB ]\n", "Total alloc-only requests",
    + printf("%-30s: %'16"PRIu64" [ %'16"PRIu64" KB ]\n", "Total alloc-only requests",
    nr_page_allocs - nr_alloc_freed,
    (total_page_alloc_bytes - total_alloc_freed_bytes) / 1024);
    printf("%-30s: %'16lu [ %'16"PRIu64" KB ]\n", "Total free-only requests",
    --
    2.1.4


    \
     
     \ /
      Last update: 2015-04-23 16:01    [W:5.686 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site