Messages in this thread | | | From | "Drokin, Oleg" <> | Subject | Re: [PATCH 1/2] vfs: export symbol 'getname' and 'putname' | Date | Wed, 22 Apr 2015 06:49:08 +0000 |
| |
On Apr 22, 2015, at 2:31 AM, Christoph Hellwig wrote:
> On Wed, Apr 22, 2015 at 06:27:11AM +0000, Drokin, Oleg wrote: >>> Nak on exporting symbols for broken staging code. Please get rid of >>> the ioctls looking up path names in horrible ways in the lustre code. >> >> For a reference, is there a good example of a non-horrible way to look up a pathname? > > Just dont do it from an ioctl, it's got an fd parameter for a reason.
I know this is not going to be a popular opinion with you, but sometimes opening a file is just too expensive. 1 RPC roudntrip to open a file and then another one to close it.
Also some files could not be opened (fs corruption).
Anyway, I got your point and there will be a solution. I was just hoping there was a way to do it because what if e.g. I need to create something new, not do something with already existing stuff, certainly there's no way to get an fd from a not yet existing fs object.
Bye, Oleg
| |