lkml.org 
[lkml]   [2015]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone
From
On Wed, Apr 22, 2015 at 10:10 AM, Josh Triplett <josh@joshtriplett.org> wrote:
>
> I do think my two-patch HAVE_COPY_THREAD_TLS series should go in fixing
> this

Ugh, I absolutely detesrt that patch.

Don't make random crazy function signatures that depend on some config
option. That's just evil. The patch is a mess of #ifdef's and should
be shot in the head and staked with a silver stake to make sure it
never re-appears.

Either:

(a) make the change for every architecture

(b) have side-by-side interfaces. With different names!

but not that disgusting "the calling conventions of these random
functions are different on different architectures and we use a config
flag to distinguish the cases".

Linus


\
 
 \ /
  Last update: 2015-04-22 20:41    [W:0.101 / U:1.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site