Messages in this thread | | | Date | Wed, 22 Apr 2015 11:22:02 -0700 | Subject | Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone | From | Linus Torvalds <> |
| |
On Wed, Apr 22, 2015 at 10:10 AM, Josh Triplett <josh@joshtriplett.org> wrote: > > I do think my two-patch HAVE_COPY_THREAD_TLS series should go in fixing > this
Ugh, I absolutely detesrt that patch.
Don't make random crazy function signatures that depend on some config option. That's just evil. The patch is a mess of #ifdef's and should be shot in the head and staked with a silver stake to make sure it never re-appears.
Either:
(a) make the change for every architecture
(b) have side-by-side interfaces. With different names!
but not that disgusting "the calling conventions of these random functions are different on different architectures and we use a config flag to distinguish the cases".
Linus
| |