lkml.org 
[lkml]   [2015]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/8] extcon: arizona: Add support for WM8998 and WM1814
Hi Richard,

On 04/21/2015 09:33 PM, Richard Fitzgerald wrote:
> Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
> ---
> drivers/extcon/extcon-arizona.c | 33 ++++++++++++++++++++++-----------
> 1 files changed, 22 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index a0ed35b..0e60787 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -1,7 +1,7 @@
> /*
> * extcon-arizona.c - Extcon driver Wolfson Arizona devices
> *
> - * Copyright (C) 2012 Wolfson Microelectronics plc
> + * Copyright (C) 2012-2014 Wolfson Microelectronics plc
> *
> * This program is free software; you can redistribute it and/or modify
> * it under the terms of the GNU General Public License as published by
> @@ -140,10 +140,14 @@ static void arizona_extcon_hp_clamp(struct arizona_extcon_info *info,
> bool clamp)
> {
> struct arizona *arizona = info->arizona;
> - unsigned int mask = 0, val = 0;
> + unsigned int mask, val = 0;
> int ret;
>
> switch (arizona->type) {
> + case WM8998:
> + case WM1814:
> + mask = 0;
> + break;
> case WM5110:
> mask = ARIZONA_HP1L_SHRTO | ARIZONA_HP1L_FLWR |
> ARIZONA_HP1L_SHRTI;
> @@ -175,17 +179,19 @@ static void arizona_extcon_hp_clamp(struct arizona_extcon_info *info,
> ret);
> }
>
> - ret = regmap_update_bits(arizona->regmap, ARIZONA_HP_CTRL_1L,
> - mask, val);
> - if (ret != 0)
> - dev_warn(arizona->dev, "Failed to do clamp: %d\n",
> + if (mask) {
> + ret = regmap_update_bits(arizona->regmap, ARIZONA_HP_CTRL_1L,
> + mask, val);
> + if (ret != 0)
> + dev_warn(arizona->dev, "Failed to do clamp: %d\n",
> ret);
>
> - ret = regmap_update_bits(arizona->regmap, ARIZONA_HP_CTRL_1R,
> - mask, val);
> - if (ret != 0)
> - dev_warn(arizona->dev, "Failed to do clamp: %d\n",
> - ret);
> + ret = regmap_update_bits(arizona->regmap, ARIZONA_HP_CTRL_1R,
> + mask, val);
> + if (ret != 0)
> + dev_warn(arizona->dev, "Failed to do clamp: %d\n",
> + ret);
> + }
>
> /* Restore the desired state while not doing the clamp */
> if (!clamp) {
> @@ -1176,6 +1182,11 @@ static int arizona_extcon_probe(struct platform_device *pdev)
> break;
> }
> break;
> + case WM8998:
> + case WM1814:
> + info->micd_clamp = true;
> + info->hpdet_ip = 2;

What is meaning of '2'? I prefer to use the definition for '2'.

Except for upper one comment, looks good to me.

Thanks,
Chanwoo Choi


\
 
 \ /
  Last update: 2015-04-22 08:21    [W:0.204 / U:1.892 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site