lkml.org 
[lkml]   [2015]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] tpm: enable PPI for TPM 2.0
    On Tue, Apr 21, 2015 at 11:58:33AM -0700, Guenter Roeck wrote:
    > On Tue, Apr 21, 2015 at 09:30:55PM +0300, Jarkko Sakkinen wrote:
    > > Enabled PPI interface to the character device sysfs directory accessible
    > > both for 1.x and 2.0 devices.
    > >
    > > The ppi group is moved from the platform device directory to the
    > > character device directory. In order to retain backwards compatibility
    > > with the 1.x devices, a symlink is created to the platform device
    > > directory.
    > >
    > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
    > > Reviewed-by: Jason Gunthorpe <jason.gunthorpe@obsidianresearch.com>
    > > ---
    > > drivers/char/tpm/tpm-chip.c | 21 +++++++++++++--------
    > > drivers/char/tpm/tpm.h | 17 ++++++-----------
    > > drivers/char/tpm/tpm_ppi.c | 34 +++++++++++-----------------------
    > > fs/kernfs/dir.c | 1 +
    > > fs/sysfs/group.c | 42 ++++++++++++++++++++++++++++++++++++++++++
    > > include/linux/sysfs.h | 8 ++++++++
    >
    > Shouldn't the sysfs changes be a separate patch ?

    Yes, I think it would make sense. I'll refine this as a patch set.
    Thanks.

    > Guenter

    /Jarkko


    \
     
     \ /
      Last update: 2015-04-22 08:21    [W:2.873 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site