lkml.org 
[lkml]   [2015]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] perf tools: Document --children option in more detail
Em Wed, Apr 22, 2015 at 03:09:06PM +0900, Namhyung Kim escreveu:
> On Tue, Apr 21, 2015 at 01:46:40PM -0300, Arnaldo Carvalho de Melo wrote:
> > > > > +--no-children option on the command line or by adding 'report.children
> > > > > += false' or 'top.children = false' in the perf config file.

> > > > One can as well use the OPTION_FOO shortening mechanism and instead use:

> > > > perf report --no-ch

> > > > Which is enough to disambiguate it from "--no-column-widths" and "--no-cpu".

> > > Are you saying that you want to add the short form instead of the full
> > > --no-chlidren name? I think we need to verbose in the manpage at
> > > least and it might not work in the future if some --chxxx option is
> > > added.

> > Perhaps:

> > "--no-children option on the command line or by adding 'report.children = false'
> > or 'top.children = false' in the perf config file.

> > A shorter form on the command line can be used, for instance '--no-ch'
> > is unambiguous at the time of this writing."

> I don't think it belongs here. The shorter form is not only for the
> --children, so it should be described in different place.

Well, I continue thinking it would add value, as the possibility of
shortening overly long options, like '--no-children' to reduce typing,
is handy, mentioning this possibility here and there, when such long
option names appears, would be of help.

But I won't insist, thanks for addressing the other suggestions,
applying.

- Arnaldo


\
 
 \ /
  Last update: 2015-04-22 14:21    [W:0.071 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site