lkml.org 
[lkml]   [2015]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/10] perf hists browser: Split popup menu actions - part 2
On Wed, Apr 22, 2015 at 04:18:19PM +0900, Namhyung Kim wrote:

SNIP

> script_browse(script_opt);
> @@ -1505,17 +1585,74 @@ do_run_script(struct hist_browser *browser __maybe_unused,
> }
>
> static int
> -do_switch_data(struct hist_browser *browser __maybe_unused, int key)
> +add_script_opt(struct hist_browser *browser __maybe_unused,
> + struct popup_action *act, char **optstr,
> + struct thread *thread, struct symbol *sym)
> +{
> + if (thread) {
> + if (asprintf(optstr, "Run scripts for samples of thread [%s]",
> + thread__comm_str(thread)) < 0)
> + return 0;
> + } else if (sym) {

.............. && sym->namelen ;-)

but I think you're right, let's see if there's (sym && !sym->namelen) case,
and fix it at the proper place.. not here

jirka


\
 
 \ /
  Last update: 2015-04-22 13:21    [W:0.236 / U:0.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site