lkml.org 
[lkml]   [2015]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/8] extcon: arizona: Add support for WM8998 and WM1814
On Wed, Apr 22, 2015 at 02:53:42PM +0900, Chanwoo Choi wrote:
> Hi Richard,
>
> > @@ -1176,6 +1182,11 @@ static int arizona_extcon_probe(struct platform_device *pdev)
> > break;
> > }
> > break;
> > + case WM8998:
> > + case WM1814:
> > + info->micd_clamp = true;
> > + info->hpdet_ip = 2;
>
> What is meaning of '2'? I prefer to use the definition for '2'.
>

'2' is the version number of the hpdet ip block in silicon. We're already using
it as a raw number '0', '1' or '2' all over extcon-arizona.c so changing it here
would mean making other patches to the file that aren't really part of adding
WM8998 support, so I'd prefer not to change that as a side-effect of adding WM8998.


> Except for upper one comment, looks good to me.
>
> Thanks,
> Chanwoo Choi


\
 
 \ /
  Last update: 2015-04-22 12:01    [W:0.132 / U:0.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site