lkml.org 
[lkml]   [2015]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] zram: remove obsolete ZRAM_DEBUG option
On (04/21/15 13:20), Marcin Jabrzyk wrote:
> This config option doesn't provide any usage for zram.
>

agree, there is no pr_debug() in the current zram. so the change
looks good to me.


btw, same stands for zsmalloc (for the time being):

#ifdef CONFIG_ZSMALLOC_DEBUG
#define DEBUG
#endif

seems to be useless. and there is even no ZSMALLOC_DEBUG config option
in mm/Kconfig.

so let's return back to it and clean up after the merge window.

-ss

> Signed-off-by: Marcin Jabrzyk <m.jabrzyk@samsung.com>
> ---
> drivers/block/zram/Kconfig | 10 +---------
> drivers/block/zram/zram_drv.c | 4 ----
> 2 files changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/block/zram/Kconfig b/drivers/block/zram/Kconfig
> index 6489c0fd0ea6..386ba3d1a6ee 100644
> --- a/drivers/block/zram/Kconfig
> +++ b/drivers/block/zram/Kconfig
> @@ -23,12 +23,4 @@ config ZRAM_LZ4_COMPRESS
> default n
> help
> This option enables LZ4 compression algorithm support. Compression
> - algorithm can be changed using `comp_algorithm' device attribute.
> -
> -config ZRAM_DEBUG
> - bool "Compressed RAM block device debug support"
> - depends on ZRAM
> - default n
> - help
> - This option adds additional debugging code to the compressed
> - RAM block device driver.
> + algorithm can be changed using `comp_algorithm' device attribute.
> \ No newline at end of file
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index fe67ebbe6c18..ea10f291d722 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -15,10 +15,6 @@
> #define KMSG_COMPONENT "zram"
> #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt
>
> -#ifdef CONFIG_ZRAM_DEBUG
> -#define DEBUG
> -#endif
> -
> #include <linux/module.h>
> #include <linux/kernel.h>
> #include <linux/bio.h>
> --
> 1.9.1
>


\
 
 \ /
  Last update: 2015-04-22 02:01    [W:0.061 / U:2.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site