lkml.org 
[lkml]   [2015]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Revert "usb: host: ehci-msm: Use devm_ioremap_resource instead of devm_ioremap"
On Tue, 21 Apr 2015, Ivan T. Ivanov wrote:

>
> On Tue, 2015-04-21 at 11:04 -0400, Alan Stern wrote:
> > On Tue, 21 Apr 2015, Ivan T. Ivanov wrote:
> >
> > > This reverts commit 70843f623b58 ("usb: host: ehci-msm: Use
> > > devm_ioremap_resource instead of devm_ioremap"), because msm_otg
> > > and this driver are using same address space to access AHB mode
> > > and USB command registers.
> >
> > Um, this patch is in fact _not_ a reversion of 70843f623b58. That
> > commit removed 4 lines of code and added 3. If this were truly a
> > reversion, it would remove 3 lines and add 4. Instead it adds 10.
> >
> > Please make this a true reversion.
>
> Right, but I will have to revert 2 commits then, is this ok?

Yes, that's okay. I hadn't noticed that e507bf577e5a touched the same
code. Just mention them both in the patch description.

Alan Stern



\
 
 \ /
  Last update: 2015-04-21 19:01    [W:0.054 / U:1.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site