lkml.org 
[lkml]   [2015]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Revert "usb: host: ehci-msm: Use devm_ioremap_resource instead of devm_ioremap"
From
Date

On Tue, 2015-04-21 at 11:04 -0400, Alan Stern wrote:
> On Tue, 21 Apr 2015, Ivan T. Ivanov wrote:
>
> > This reverts commit 70843f623b58 ("usb: host: ehci-msm: Use
> > devm_ioremap_resource instead of devm_ioremap"), because msm_otg
> > and this driver are using same address space to access AHB mode
> > and USB command registers.
>
> Um, this patch is in fact _not_ a reversion of 70843f623b58. That
> commit removed 4 lines of code and added 3. If this were truly a
> reversion, it would remove 3 lines and add 4. Instead it adds 10.
>
> Please make this a true reversion.

Right, but I will have to revert 2 commits then, is this ok?

Ivan


\
 
 \ /
  Last update: 2015-04-21 18:01    [W:0.093 / U:3.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site