[lkml]   [2015]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] ARM: at91/dt: kizbox: update and rename to at91-kizbox
Hi Gael,

On Mon, 20 Apr 2015 11:13:38 +0200
Gaël PORTAY <> wrote:

> Sort nodes, rename to match Atmel naming convention

You should use -M when you generate your patches with format-patch: it
keeps track of files that have been renamed instead of considering it
as a removal + an addition.

> and update the features
> below:
> - command-line,
> - use proper serial uart,
> - rename leds and gpio-keys,
> - update to pwm-leds and
> - fix gpio-key level.

Please split this patch so we can easily review the changes.
How about the following separation ?

- rename dts file
- use stdout-path
- sanitize bootargs
- led related changes (rename + pwm-leds)
- gpio-key related changes (rename + fix level)

Best Regards,


Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering

 \ /
  Last update: 2015-04-21 09:41    [W:0.052 / U:7.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site