lkml.org 
[lkml]   [2015]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] genirq: check irq_ack callback in handle_edge_irq() before calling
From
On Tue, Apr 21, 2015 at 5:40 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> No, it's not missing by chance. It's missing on purpose. The edge
> handler is designed to deal with edge type interrupt chips and those
> have an ACK by definition.
>
> You are fixing the wrong place. That GPIO expander is using the wrong
> flow handler. It should not use the edge handler at all.

Just missed comments for handle_edge_irq() function, explaining why
irq_ack is mandatory. So I just need to use handle_level_irq() in expander
driver (instead of handle_edge_irq()).

Thanks!


\
 
 \ /
  Last update: 2015-04-21 17:41    [W:0.036 / U:1.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site