lkml.org 
[lkml]   [2015]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/3] Drivers: hv: vmbus: do cleanup on all vmbus_open() failure paths
Date
Dan Carpenter <dan.carpenter@oracle.com> writes:

> On Tue, Apr 21, 2015 at 10:17:52AM +0200, Vitaly Kuznetsov wrote:
>> diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
>> index 54da66d..836386f 100644
>> --- a/drivers/hv/channel.c
>> +++ b/drivers/hv/channel.c
>> @@ -186,11 +186,12 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 send_ringbuffer_size,
>> list_del(&open_info->msglistentry);
>> spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags);
>>
>> - if (err == 0)
>> - newchannel->state = CHANNEL_OPENED_STATE;
>> + if (err != 0)
>
> Doesn't the double negative not make it slightly more confusing?
>

Point taken, will fix in v2 :-)

> regards,
> dan carpenter

--
Vitaly


\
 
 \ /
  Last update: 2015-04-21 14:21    [W:0.054 / U:7.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site