lkml.org 
[lkml]   [2015]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf: annotate: make it respect -i option.
On 2015/4/2 16:12, Namhyung Kim wrote:
> On Thu, Apr 02, 2015 at 06:04:52AM +0000, Wang Nan wrote:
>> There is a bug in perf annotate that it doesn't respect user provided
>> '-i'/'--input' option:
>>
>> # perf record ls
>> [ perf record: Woken up 1 times to write data ]
>> [ perf record: Captured and wrote 0.001 MB perf.data (8 samples) ]
>> # mv ./perf.data ./perf.data.new
>> # perf annotate -i ./perf.data.new --stdio
>> failed to open perf.data: No such file or directory (try 'perf record' first)
>>
>> This patch fix it by setting file path after option parsing, like
>> what 'perf report' does.
>>
>> Signed-off-by: Wang Nan <wangnan0@huawei.com>
>
> I guess other commands are also suffered from this bug.. anyway,
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
>
> Thanks,
> Namhyung
>

Hi,

Looks like the next patch 'perf kmem: Respect -i option' has already been collected
by tip/master, but this patch is lost. Is there any problem?

Thank you!




\
 
 \ /
  Last update: 2015-04-21 05:21    [W:0.103 / U:1.972 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site