lkml.org 
[lkml]   [2015]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH 5/5] Input: elan_i2c - Correct the x and y trace number.
From
Date
Hi Dmitry,

How about the description? Is it looks good for you?
Please let me know if you have any concern.

----------------------------------------------
Thank you,
ELAN Duson
✉ Email: dusonlin@emc.com.tw
----------------------------------------------





> duson <dusonlin@emc.com.tw> 於 2015年4月16日 上午9:37 寫道:
>
> Hi Dmitry,
>
> I double check with our firmware team and the SPEC, it looks like the subtract 1 just a misunderstanding.
> So, the correct should not subtract 1. For example, if the touchpad x resolution is 2800 and x trace number is 20,
> the pitch size of x should be 2800/20 = 140, not 2800/19 = 147.36.
>
> ----------------------------------------------
> Thanks,
> ELAN Duson
> ✉ Email: dusonlin@emc.com.tw
> ----------------------------------------------
>
>
>
>
>
>> Dmitry Torokhov <dmitry.torokhov@gmail.com> 於 2015年4月16日 上午1:47 寫道:
>>
>> On Wed, Apr 15, 2015 at 09:55:43AM +0800, DusonLin wrote:
>>> The trace number does not need to subtract 1 now.
>>
>> Could you provide a bit more of background for this change? Why don't we
>> need to decrement the number returned by the firmware anymore? We have
>> been running with the old numbers for many years...
>>
>> Thanks!
>>
>>>
>>> Signed-off-by: Duson Lin <dusonlin@emc.com.tw>
>>> ---
>>> drivers/input/mouse/elan_i2c_i2c.c | 4 ++--
>>> drivers/input/mouse/elan_i2c_smbus.c | 4 ++--
>>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/input/mouse/elan_i2c_i2c.c
>>> b/drivers/input/mouse/elan_i2c_i2c.c
>>> index 029941f..550f905 100644
>>> --- a/drivers/input/mouse/elan_i2c_i2c.c
>>> +++ b/drivers/input/mouse/elan_i2c_i2c.c
>>> @@ -356,8 +356,8 @@ static int elan_i2c_get_num_traces(struct i2c_client
>>> *client,
>>> return error;
>>> }
>>>
>>> - *x_traces = val[0] - 1;
>>> - *y_traces = val[1] - 1;
>>> + *x_traces = val[0];
>>> + *y_traces = val[1];
>>>
>>> return 0;
>>> }
>>> diff --git a/drivers/input/mouse/elan_i2c_smbus.c
>>> b/drivers/input/mouse/elan_i2c_smbus.c
>>> index 06a2bcd..0b04151 100644
>>> --- a/drivers/input/mouse/elan_i2c_smbus.c
>>> +++ b/drivers/input/mouse/elan_i2c_smbus.c
>>> @@ -268,8 +268,8 @@ static int elan_smbus_get_num_traces(struct i2c_client
>>> *client,
>>> return error;
>>> }
>>>
>>> - *x_traces = val[1] - 1;
>>> - *y_traces = val[2] - 1;
>>> + *x_traces = val[1];
>>> + *y_traces = val[2];
>>>
>>> return 0;
>>> }
>>>
>>
>> --
>> Dmitry
>>
>



\
 
 \ /
  Last update: 2015-04-21 03:01    [W:0.049 / U:2.020 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site