Messages in this thread |  | | Date | Mon, 20 Apr 2015 21:37:03 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] spi: rb4xx: Fix set_cs logic. |
| |
On Mon, Apr 20, 2015 at 03:53:25PM +0200, Bert Vermeulen wrote: > As it turns out, the set_cs() enable parameter refers to the logic level > on the CS pin, not the state of chip selection.
> This broke functionality of the LEDs behind the CPLD, or at least delayed > the commands until another one came in to toggle CS.
No, the enable parameter *should* refer to chip select assertion (see how we handle GPIO chip selects). However it's possible that this device has an inverted chip select and should be registered with the SPI_CS_HIGH flag? [unhandled content-type:application/pgp-signature] |  |