lkml.org 
[lkml]   [2015]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] spi: rb4xx: Fix set_cs logic.
On Mon, Apr 20, 2015 at 03:53:25PM +0200, Bert Vermeulen wrote:
> As it turns out, the set_cs() enable parameter refers to the logic level
> on the CS pin, not the state of chip selection.

> This broke functionality of the LEDs behind the CPLD, or at least delayed
> the commands until another one came in to toggle CS.

No, the enable parameter *should* refer to chip select assertion (see
how we handle GPIO chip selects). However it's possible that this
device has an inverted chip select and should be registered with the
SPI_CS_HIGH flag?
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-04-20 22:41    [W:0.056 / U:0.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site