[lkml]   [2015]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: [PATCH 2/9][v2]usb:fsl:otg: Add support to add/remove usb host driver
On Mon, 20 Apr 2015, Ramneek Mehresh wrote:

> > > This is the wrong way to connect platform-private data with the
> > > ehci_hcd structure. The right way is to use an ehci_driver_overrides
> > > structure, like in ehci-omap.c and quite a few other EHCI platform drivers.
> > >
> >
> Hi Alan, I checked again...we are not connecting ehci_hcd structure here with
> platform-private data. We are just having a wrapper on it to have some additional
> Information that can be used for ehci fsl driver. This additional information is
> private to ehci fsl driver, and is mainly used for otg driver functionality and to
> save/restore fsl regsiters during deep-sleep

It doesn't matter -- private data is private data, whether it is
platform-private or driver-private.

Either way, you can't wrap ehci-hcd in anything. The private data has
to added to the end, the way ehci-omap.c does it.

Alan Stern

 \ /
  Last update: 2015-04-20 20:21    [W:0.065 / U:8.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site