lkml.org 
[lkml]   [2015]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arm64: Implement 1-,2- byte smp_load_acquire and smp_store_release
On Mon, Apr 20, 2015 at 05:08:37PM +0100, Linus Torvalds wrote:
> On Mon, Apr 20, 2015 at 8:45 AM, Andrey Ryabinin <a.ryabinin@samsung.com> wrote:
> >
> > Commit 8053871d0f7f ("smp: Fix smp_call_function_single_async() locking")
> > started to use smp_load_acquire() to load 2-bytes csd->flags.
> > That crashes arm64 kernel during the boot.
>
> Ahh. I don't disagree with your patch, but we should just make
> csd->flags be an "int" regardless of this issue.
>
> There is absolutely no reason to try to use 16-bit words. It doesn't
> save us any space (alignment), and it's just a *bad* idea to depend on
> any kind of atomicity of 16-bit entities. Bytes, yes. Words, yes. But
> 16-bit half-words? There's no point.
>
> So I'll make it "unsigned int" instead of "u16".
>
> But as said, the ARM64 patch definitely is a good idea regardless.

Sounds good to me and means I can leave the pull for a day or two to see
if any other arm64 fixes queue up.

Will


\
 
 \ /
  Last update: 2015-04-20 18:41    [W:0.041 / U:5.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site