lkml.org 
[lkml]   [2015]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] regulator: max8973: get rid of extra variable for gpio validity
On Mon, Apr 20, 2015 at 06:24:15PM +0530, Laxman Dewangan wrote:
> To find that dvs-gpio is valid or not, gpio API gpio_is_valid()
> can be directly used instead of intermediate variable.

> Removing the extra variable and using the gpio_is_valid().

This still looks like it's got the same issue with not doing the right
thing with platform data that uses zero as a default which is the point
in having a flag like this.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-04-20 17:21    [W:0.122 / U:1.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site