lkml.org 
[lkml]   [2015]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 02/14] MIPS: ath79: Add basic device tree support
    From
    Date
    On Sat, 2015-04-18 at 18:31 +0200, Alban wrote:
    > On Sat, 18 Apr 2015 09:05:52 +0200
    > Paul Bolle <pebolle@tiscali.nl> wrote:
    >
    > > On Fri, 2015-04-17 at 16:24 +0200, Alban Bedel wrote:
    > >
    > > > --- a/arch/mips/ath79/Kconfig
    > > > +++ b/arch/mips/ath79/Kconfig
    > > >
    > > > +choice
    > > > + prompt "Builtin devicetree selection"
    > > > + default DTB_ATH79_NONE
    > > > + help
    > > > + Select the devicetree.
    > > > +
    > > > + config DTB_ATH79_NONE
    > > > + bool "None"
    > > > +endchoice
    > >
    > > This adds a choice block with one config entry. So what this achieves
    > > is that DTB_ATH79_NONE will always be 'y', right? Besides I didn't
    > > notice on a user of CONFIG_DTB_ATH79_NONE. So as far as I can see
    > > this choice has no effect on the build.
    > >
    > > Why was this choice entry added?
    >
    > This menu is for boards that need a built-in DTB, as MIPS currently
    > doesn't support appended DTBs it is the only way to load a DTB on
    > boards stuck with a broken boot loader. But as no board has been added
    > yet it only contain the entry for boards that don't need a built-in
    > DTB, which do nothing as you pointed out.
    >
    > A board is then added in this menu in patch 14, for some reasons git
    > send-email didn't send the whole serie at once :(

    I saw 14/14 fly by now. (And I saw 12/12 of v2, which basically replaces
    14/14.) That makes things clear.

    Perhaps, if you're going to send a v3, you might move this change into
    12/12. At least, I see little reason to add this choice block in two
    separate steps in this series.

    (Side note: you _might_ be able to drop config DTB_ATH79_NONE entirely
    if you also replace
    default DTB_ATH79_NONE

    with
    optional

    optional is a little used option for choice blocks. I haven't tested
    this, so this suggestion could end up wasting your time. And even then
    this all looks like a complicated way to set just DTB_TL_WR1043ND_V1. I
    suppose you expect to add things to this choice block in the future.)

    Thanks,


    Paul Bolle



    \
     
     \ /
      Last update: 2015-04-20 12:21    [W:2.951 / U:0.364 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site