lkml.org 
[lkml]   [2015]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/7] perf tools: Move TUI-specific fields to struct hist_entry_tui
On Sun, Apr 19, 2015 at 01:04:11PM +0900, Namhyung Kim wrote:
> Since perf diff only support stdio output, TUI fields are only accessed
> from perf report (or perf top). So add new struct hist_entry_tui and
> move those fields into them. And include it as an union member.
>

SNIP

>
> - /* XXX These two should move to some tree widget lib */
> - u16 row_offset;
> - u16 nr_rows;
> -
> bool init_have_children;
> char level;
> u8 filtered;
> + union {
> + struct hist_entry_diff diff;
> + struct hist_entry_tui tui;
> + };

could you please add the comment from changelog in here,
so it's easy to figure this out in the future

thanks,
jirka


\
 
 \ /
  Last update: 2015-04-20 11:01    [W:0.133 / U:1.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site