lkml.org 
[lkml]   [2015]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] mvneta: implement SGMII-based in-band link state signaling
    From
    From: Stas Sergeev <stsp@list.ru>
    Date: Tue, 31 Mar 2015 16:24:59 +0300

    > @@ -2590,6 +2651,7 @@ static int mvneta_mdio_probe(struct mvneta_port *pp)
    >
    > static void mvneta_mdio_remove(struct mvneta_port *pp)
    > {
    > + fixed_phy_set_link_update(pp->phy_dev, NULL);

    I do not see any other driver doing this on shutdown.
    Please show me why it is necessary.

    And if it is, all other drivers registering a fixed phy link update
    function need to be adjusted to do the same thing.


    \
     
     \ /
      Last update: 2015-04-03 03:21    [W:2.199 / U:0.744 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site