Messages in this thread | | | Date | Thu, 02 Apr 2015 21:19:12 +0200 | From | Andrea Scian <> | Subject | Re: [PATCH 4/4] UBI: Implement bitrot checking |
| |
Il 02/04/2015 19:54, Richard Weinberger ha scritto: > Hi! > > Am 02.04.2015 um 19:34 schrieb Andrea Scian: >> Richard, >> >> Il 29/03/2015 14:13, Richard Weinberger ha scritto: >>> + mutex_lock(&ubi->buf_mutex); >>> + err = ubi_io_read(ubi, ubi->peb_buf, e->pnum, 0, ubi->peb_size); >>> + mutex_unlock(&ubi->buf_mutex); >>> + if (err == UBI_IO_BITFLIPS) { >>> + dbg_wl("found bitflips in PEB %d", e->pnum); >>> + spin_lock(&ubi->wl_lock); >>> + >> IIUC you trigger the action as soon as you have a bitflip error, is this >> correct? > I trigger it as soon UBI sees the bitflip. This depends on the configured MTD > bitflip_threshold.
ops.. I confused UBI bitflip error with MTD bitflip error ;-) thanks for point this out and help me understanding the code
now it's clear and it sounds good to me
Kind Regards,
--
Andrea SCIAN
DAVE Embedded Systems
| |