Messages in this thread | | | Date | Thu, 2 Apr 2015 09:49:34 -0400 | From | Steven Rostedt <> | Subject | Re: [RFC][PATCH 01/17 v2] tracing: Add TRACE_SYSTEM_VAR to intel-sst |
| |
On Thu, 2 Apr 2015 14:40:33 +0100 Mark Brown <broonie@kernel.org> wrote:
> On Thu, Apr 02, 2015 at 09:33:41AM -0400, Steven Rostedt wrote: > > Steven Rostedt <rostedt@goodmis.org> wrote: > > > > I couldn't find anything in MAINTAINERS about that file, but I didn't > > > look for your name though. > > > BTW, was that considered an Acked-by? > > I guess, you probably want to ping the Intel guys though since it's them > that would be affected by the interface change.
Actually, there's no interface change. This is the work-around patch to that. It's only internal to the kernel and userspace does not see any difference.
I just needed a unique TRACE_SYSTEM name that was also a valid C variable, and now use TRACE_SYSTEM_VAR.
The ftrace code now has:
#ifndef TRACE_SYSTEM_VAR #define TRACE_SYSTEM_VAR TRACE_SYSTEM #endif
And this allows trace headers (like intel-sst.h) to have a different VAR variable from the TRACE_SYSTEM name:
#define TRACE_SYSTEM intel-ssl
#define TRACE_SYSTEM_VAR intel_ssl
This lets me use something that will work and not need to change what the user space sees.
-- Steve
| |