lkml.org 
[lkml]   [2015]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()
On 2015/4/20 10:09, Gu Zheng wrote:

> Hi Ishimatsu, Xishi,
>
> On 04/20/2015 10:11 AM, Yasuaki Ishimatsu wrote:
>
>>
>>> When hot adding memory and creating new node, the node is offline.
>>> And after calling node_set_online(), the node becomes online.
>>>
>>> Oh, sorry. I misread your ptaches.
>>>
>>
>> Please ignore it...
>
> Seems also a misread to me.
> I clear it (my worry) here:
> If we set the node size to 0 here, it may hidden more things than we experted.
> All the init chunks around with the size (spanned/present/managed...) will
> be non-sense, and the user/caller will not get a summary of the hot added node
> because of the changes here.
> I am not sure the worry is necessary, please correct me if I missing something.
>
> Regards,
> Gu
>

Hi Gu,

My patch is just set size to 0 when hotadd a node(old or new). I know your worry,
but I think it is not necessary.

When we calculate the size, it uses "arch_zone_lowest_possible_pfn[]" and "memblock",
and they are both from boot time. If we hotadd a new node, the calculated size is
0 too. When add momery, __add_zone() will grow the size and start.

Thanks,
Xishi Qiu



\
 
 \ /
  Last update: 2015-04-20 05:21    [W:0.089 / U:3.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site