lkml.org 
[lkml]   [2015]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()
On 2015/4/18 4:05, Yasuaki Ishimatsu wrote:

>
> Your patches will fix your issue.
> But, if BIOS reports memory first at node hot add, pgdat can
> not be initialized.
>
> Memory hot add flows are as follows:
>
> add_memory
> ...
> -> hotadd_new_pgdat()
> ...
> -> node_set_online(nid)
>
> When calling hotadd_new_pgdat() for a hot added node, the node is
> offline because node_set_online() is not called yet. So if applying
> your patches, the pgdat is not initialized in this case.
>
> Thanks,
> Yasuaki Ishimatsu
>

Hi Yasuaki,

I'm not quite understand, when BIOS reports memory first, why pgdat
can not be initialized?
When hotadd a new node, hotadd_new_pgdat() will be called too, and
when hotadd memory to a existent node, it's no need to call hotadd_new_pgdat(),
right?

Thanks,
Xishi Qiu



\
 
 \ /
  Last update: 2015-04-20 04:41    [W:0.092 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site