Messages in this thread |  | | Date | Mon, 20 Apr 2015 00:01:18 +0200 | From | Mateusz Kulikowski <> | Subject | Re: [PATCH 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr() |
| |
Hi Joe,
On 19.04.2015 22:20, Joe Perches wrote: (...) >> +# check for memset(foo, 0xFF, ETH_ALEN) that could be eth_broadcast_addr >> + if ($^V && $^V ge 5.10.0 && >> + $line =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/s) { > > Please align the $line with the $^V above it.
Thanks for review - I'll post v2 soon; Sorry for alignment issues - shame on me and my editor.
(I've found that PATCH 1/2 was also not aligned - will fix it as well)
Regards, Mateusz
|  |