Messages in this thread | | | Date | Sat, 18 Apr 2015 21:23:27 -0700 | From | Guenter Roeck <> | Subject | Re: sparc64: Build failure due to commit f1600e549b94 (sparc: Make sparc64 use scalable lib/iommu-common.c functions) |
| |
On 04/18/2015 09:13 PM, Guenter Roeck wrote: > On 04/18/2015 02:41 PM, David Miller wrote: >> From: Sowmini Varadhan <sowmini.varadhan@oracle.com> >> Date: Sat, 18 Apr 2015 15:55:14 -0400 >> >>>> >>>> Sowmini, I think I sorted this out in the 'sparc' GIT tree. >>>> >>>> Can you take a look? >>> >>> The patches look right now. These are the commit-ids I checked >>> >>> ff7d37a502022149655c18035b99a53391be0383 >>> bb620c3d3925aec0ed4f21010c86df08ec18a8c7 >>> 0ae53ed15d9b87b883b593a9884957cfa4fc2480 >> >> Thanks for checking, I'll get this to Linus ASAP. >> > Latest upstream (v4.0-8110-g64fb1d0) passes my tests. >
I spoke too early. Now I get a similar failure in the powerpc:allmodconfig build (which previously failed for a different reason).
lib/built-in.o:(.discard+0x1): multiple definition of `__pcpu_unique_iommu_pool_hash' arch/powerpc/kernel/built-in.o:(.discard+0x18): first defined here
And, yes, there are still two instances of iommu_pool_hash.
arch/powerpc/kernel/iommu.c:static DEFINE_PER_CPU(unsigned int, iommu_pool_hash); lib/iommu-common.c:static DEFINE_PER_CPU(unsigned int, iommu_pool_hash);
Guenter
| |