lkml.org 
[lkml]   [2015]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V4] Fix pointer cast for 32 bits arch
On Sat, Apr 18, 2015 at 03:34:08PM +0200, Peter Senna Tschudin wrote:
>
>
> On Fri, Apr 17, 2015 at 4:10 PM, Alan Cox <alan@linux.intel.com> wrote:
> > On Fri, 2015-04-17 at 16:59 +0300, Dan Carpenter wrote:
> >> On Fri, Apr 17, 2015 at 02:31:49PM +0100, Alan Cox wrote:
> >> > On Fri, 2015-04-17 at 11:20 +0300, Dan Carpenter wrote:
> >> > > Actually, my patch seems like a good idea to me but it's one of those
> >> > > things that someone should probably test. Unless someone can test
> >> > > goldfish on a 32 bit system with 64 bit dma addresses
> >> >
> >> > No such "system" exists.
> >>
> >> I don't understand. We definitely can have 64bit dma addresses on
> >> x86_32.
> >
> >
> > Yes but no actual Goldfish environment is built that way
> Isn't this a simpler fix?

I still think my fix is cleanest even though dma_addr_t and size_t are
always the same. It just means that we can commit it without worrying
about testing.

regards,
dan carpenter



\
 
 \ /
  Last update: 2015-04-18 16:41    [W:0.046 / U:1.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site