lkml.org 
[lkml]   [2015]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 1/2] tee: generic TEE subsystem
On Fri, Apr 17, 2015 at 09:50:56AM +0200, Jens Wiklander wrote:
> +struct tee_device {
> + char name[TEE_MAX_DEV_NAME_LEN];
> + const struct tee_desc *desc;
> + struct device *dev;

No, please embed the device in your structure, don't have a pointer to
it.

> + struct miscdevice miscdev;

This can be a pointer, as the lifecycle of your device is not dictated
by the miscdevice, but rather the 'struct device'.

> +
> + void *driver_data;

You don't need this, use 'struct device''s pointer instead.

> +
> + struct list_head list_shm;
> + struct tee_shm_pool *pool;
> +};


\
 
 \ /
  Last update: 2015-04-18 11:01    [W:0.255 / U:0.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site