Messages in this thread | | | Date | Sat, 18 Apr 2015 10:57:12 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [RFC PATCH 1/2] tee: generic TEE subsystem |
| |
On Fri, Apr 17, 2015 at 09:50:56AM +0200, Jens Wiklander wrote: > +struct tee_device { > + char name[TEE_MAX_DEV_NAME_LEN]; > + const struct tee_desc *desc; > + struct device *dev;
No, please embed the device in your structure, don't have a pointer to it.
> + struct miscdevice miscdev;
This can be a pointer, as the lifecycle of your device is not dictated by the miscdevice, but rather the 'struct device'.
> + > + void *driver_data;
You don't need this, use 'struct device''s pointer instead.
> + > + struct list_head list_shm; > + struct tee_shm_pool *pool; > +};
| |