Messages in this thread | | | Date | Fri, 17 Apr 2015 10:14:18 -0700 | From | Mike Kravetz <> | Subject | Re: [RFC PATCH 3/4] hugetlbfs: add hugetlbfs_fallocate() |
| |
On 04/17/2015 01:00 AM, Hillf Danton wrote: >> + clear_huge_page(page, addr, pages_per_huge_page(h)); >> + __SetPageUptodate(page); >> + error = huge_add_to_page_cache(page, mapping, index); >> + if (error) { >> + put_page(page); >> + /* Keep going if we see an -EEXIST */ >> + if (error != -EEXIST) >> + goto out; /* FIXME, need to free? */ >> + } >> + >> + /* >> + * page_put due to reference from alloc_huge_page() >> + * unlock_page because locked by add_to_page_cache() >> + */ >> + put_page(page); > > Still needed if EEXIST?
Nope. Good catch.
I'll fix this in the next version. -- Mike Kravetz
| |