lkml.org 
[lkml]   [2015]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 3/4] ARM: dts: UniPhier: add support for UniPhier SoCs and boards
Date
On Saturday 18 April 2015 00:48:17 Masahiro Yamada wrote:
> +
> + smp_syscon@59801208 {
> + compatible = "socionext,uniphier-smp-reg", "syscon";
> + reg = <0x59801208 0x4>;
> + };
> +
>

Using syscon here is a good idea, but please name the register area
according to what it is called in the data sheet, not according to how
it is used in Linux, and list all the registers that belong in this
device. It's quite possible that another driver needs a second
register from the same syscon.

E.g. if there is a device called a foo controller, make this device

foo-controller@0x59800000 {
compatible = "socionext,uniphier-foo-controller", "syscon";
reg = <0x59800000 0x4000>;
};

then hardcode the 0x1208 offset in the smp code, or add it as an
argument to the property containing the phandle.

Arnd


\
 
 \ /
  Last update: 2015-04-17 18:21    [W:0.059 / U:0.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site