lkml.org 
[lkml]   [2015]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [LKP] [mtd] 6b44d910ae7: WARNING: CPU: 0 PID: 0 at kernel/locking/lockdep.c:3547 check_flags+0xae/0x17b()
From
On Thu, Apr 16, 2015 at 9:34 AM, Frans Klaver <fransklaver@gmail.com> wrote:
> On Thu, Apr 16, 2015 at 7:27 AM, Huang Ying <ying.huang@intel.com> wrote:
>> FYI, we noticed the below changes on
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> commit 6b44d910ae7de5316fcf1fc828ff4a8d48cac5e2 ("mtd: core: set some defaults when dev.parent is set")
>>
>> <panic>
>
> I would then expect that this is actually caused by
> 29b4dacc55b0cb079e5b4be2fbc494e138a7d110 (mtd: nand: docg4: show
> parent device in sysfs), which effectively replaces mtd->owner with
> the automated value. I just noticed that
> module_platform_driver_probe() doesn't set the owner like
> module_platform_driver() does.

Or not. I should probably get more sleep somewhere. omap2 uses
module_platform_driver but still requires .driver.owner to be set to
THIS_MODULE.

From the looks of it only platform_driver_register() provides the
nicety of automatically filling in the module owner. This still seems
to be an API inconsistency to me.

> I'm happy to
> send in a patch that restores "mtd->owner = THIS_MODULE" with these
> drivers, if that's preferred.

Long story short, I should fix it.

Brian, do you prefer a rework of the series or a patch fixing it?

Frans


\
 
 \ /
  Last update: 2015-04-17 17:01    [W:0.152 / U:1.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site