lkml.org 
[lkml]   [2015]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] First batch of KVM changes for 4.1
On Fri, Apr 17, 2015 at 12:38:07PM +0200, Paolo Bonzini wrote:
>
>
> On 17/04/2015 12:36, Peter Zijlstra wrote:
> > Now you make everybody pay for your crap, x86-64 paravirt or not. Keep
> > the cost by those who need it.
> >
> > Please take it out, ASAP.
>
> I'll just implement the static key.

Can you first show that:

preempt_out:
int cpu = smp_processor_id();
if (vcpu->cpu != cpu)
vcpu->cpu = cpu;

preempt_in:
int cpu = smp_processor_id();
if (unlikely(vcpu->cpu != cpu))
do_vcpu_migration_callback(cpu);

Is actually a measurable performance hit and we actually _need_ the
migration callback?

Also, it looks like you already do exactly this for other things, look
at:

kvm_sched_in()
kvm_arch_vcpu_load()
if (unlikely(vcpu->cpu != cpu) ... )

So no, I don't believe for one second you need this.


\
 
 \ /
  Last update: 2015-04-17 13:01    [W:0.067 / U:10.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site