[lkml]   [2015]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

On 04/16/2015 05:58 PM, Jason Gunthorpe wrote:
> On Thu, Apr 16, 2015 at 10:08:10AM +0200, Michael Wang wrote:
>> Use raw management helpers to reform cm related part in IB-core cma/ucm.
>> These checks focus on the device cm type rather than the port capability,
>> directly pass port 1 works currently, but can't support mixing cm type
>> device in future.
> After the discussion settled, I ended up thinking that implementing
> explicit device checks, for use by CM, and the BUG_ON at register to
> require all ports have the same value was the best option.
> It also looks like hardwired 1 won't work on switch ports, so it is no-go.

AFAIK, the current HW won't trigger such Bug, actually only mlx4 using port_num
to check the link-layer (but still ib cm anyway), others are just static whatever
the port_num is.

Thus as long as the check is still count on transport type and link-layer, the
BUG may never be triggered...

Michael Wang

> Jason

 \ /
  Last update: 2015-04-17 11:01    [W:0.115 / U:2.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site