lkml.org 
[lkml]   [2015]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] net: dsa: register hwmon for any provided function
Hi Guenter,

> > switch (index) {
> > + case 0: /* temp1_input */
> > + if (drv->get_temp)
> > + mode |= S_IRUGO;
>
> This should be mandatory. Sorry, I don't really understand what you are
> trying to accomplish here.
>
> Can you give me a real world example where a chip would support setting
> a limit but not reading it ?

I have no such example. I just did not see why this couldn't be allowed
(e.g. setting only set_temp_limit and get_temp_alarm looks fine to me).
But if you say that get_temp should be mandatory, I'm OK with that.

The primary goal of this patchset was to use DEVICE_ATTR_RW to declare
temp1_max, instead of reflecting the minimal permissions needed.

Best,
-v


\
 
 \ /
  Last update: 2015-04-17 00:41    [W:0.068 / U:5.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site