[lkml]   [2015]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/2] net: dsa: use DEVICE_ATTR_RW to declare temp1_max

On 04/16/2015 09:38 PM, Vivien Didelot wrote:

> Since commit da4759c, sysfs will only use the permissions returned by

Please also specify that commit's summary line in parens.

> is_visible, instead of OR'ing them with the default file mode.

> This allows us to declare temp1_max with the DEVICE_ATTR_RW macro and
> just return the desired permissions for the hwmon sysfs attributes in
> dsa_hwmon_attrs_visible.

> Also, allow temp1_max to be write-only if set_temp_limit is provided,
> but not get_temp_limit.

> Signed-off-by: Vivien Didelot <>

WBR, Sergei

 \ /
  Last update: 2015-04-16 21:01    [W:0.088 / U:7.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site