Messages in this thread |  | | From | "Hefty, Sean" <> | Subject | RE: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm | Date | Thu, 16 Apr 2015 14:31:34 +0000 |
| |
> > This is equivalent to today where the checks are per node rather than > > per port. > > > > Should all checks here be port 1 based or only certain ones like listen > > ? For example, in connect/reject/disconnect, don't we already have port > > ? Guess this can be dealt with later as this is not a regression from > > the current implementation. > > Yeah, these parts of cma may need more carve in future, like some new > callback > for different CM type as Sean suggested. > > Maybe directly using 1 could help to highlight the problem ;-)
Only a few checks need to be per device. I think I pointed those out previously. Testing should show anywhere that we miss fairly quickly, since port would still be 0. For the checks that can be updated to be per port, I would rather go ahead and convert them.
- Sean
|  |