lkml.org 
[lkml]   [2015]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 27/27] IB/Verbs: Cleanup rdma_node_get_transport()


On 04/16/2015 03:36 PM, Hal Rosenstock wrote:
[snip]
>> -EXPORT_SYMBOL(rdma_node_get_transport);
>> -
>> enum rdma_link_layer rdma_port_get_link_layer(struct ib_device *device, u8 port_num)
>> {
>> if (device->get_link_layer)
>> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
>> index 262bf44..f9ef479 100644
>> --- a/include/rdma/ib_verbs.h
>> +++ b/include/rdma/ib_verbs.h
>> @@ -84,9 +84,6 @@ enum rdma_transport_type {
>> RDMA_TRANSPORT_IBOE,
>> };
>>
>> -__attribute_const__ enum rdma_transport_type
>> -rdma_node_get_transport(enum rdma_node_type node_type);
>> -
>> enum rdma_link_layer {
>> IB_LINK_LAYER_UNSPECIFIED,
>
> Is IB_LINK_LAYER_UNSPECIFIED still possible ?

Actually it's impossible in kernel at first, all those who implemented the callback
won't return UNSPECIFIED, others all have the correct transport type (otherwise BUG())
and won't result UNSPECIFIED :-)

Regards,
Michael Wang

>
>> IB_LINK_LAYER_INFINIBAND,


\
 
 \ /
  Last update: 2015-04-16 16:21    [W:0.081 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site