lkml.org 
[lkml]   [2015]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()
On 4/15/2015 4:33 PM, ira.weiny wrote:
> On Wed, Apr 15, 2015 at 02:36:13PM -0400, Hal Rosenstock wrote:
>> On 4/13/2015 8:22 AM, Michael Wang wrote:
>>> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
>>> index 65994a1..d54f91e 100644
>>> --- a/include/rdma/ib_verbs.h
>>> +++ b/include/rdma/ib_verbs.h
>>> @@ -75,10 +75,13 @@ enum rdma_node_type {
>>> };
>>>
>>> enum rdma_transport_type {
>>> + /* legacy for users */
>>> RDMA_TRANSPORT_IB,
>>> RDMA_TRANSPORT_IWARP,
>>> RDMA_TRANSPORT_USNIC,
>>> - RDMA_TRANSPORT_USNIC_UDP
>>> + RDMA_TRANSPORT_USNIC_UDP,
>>> + /* new transport */
>>> + RDMA_TRANSPORT_IBOE,
>>> };
>>>
>>> __attribute_const__ enum rdma_transport_type
>>> @@ -1501,6 +1504,8 @@ struct ib_device {
>>> int (*query_port)(struct ib_device *device,
>>> u8 port_num,
>>> struct ib_port_attr *port_attr);
>>> + enum rdma_transport_type (*query_transport)(struct ib_device *device,
>>> + u8 port_num);
>>> enum rdma_link_layer (*get_link_layer)(struct ib_device *device,
>>> u8 port_num);
>>> int (*query_gid)(struct ib_device *device,
>>
>> libibverbs also exposes transport at the device level. Isn't a change to
>> make transport per port rather than per device needed there as well to
>> be consistent with these proposed kernel changes ? If so, would the
>> additional IBoE transport be exposed ? We also need to worry about
>> backward compatibility for existing applications.
>
> Early on in this thread we agreed that user space would stay the same until we
> get the kernel straightened out.

I missed that in this very long thread. I just wanted to be sure that
this will be addressed.

-- Hal

> The above enum and function are not exported
> to user space so I believe this is in alignment with that plan.
>
> Ira
>
> .
>



\
 
 \ /
  Last update: 2015-04-16 14:21    [W:0.098 / U:1.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site