lkml.org 
[lkml]   [2015]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch for 4.0] x86: silence warning in /dev/mem support

* Pavel Machek <pavel@ucw.cz> wrote:

> The compiler is right, the code is tricky, but it is also correct
> AFAICT.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
> index fdf617c..8a8dce8 100644
> --- a/arch/x86/mm/ioremap.c
> +++ b/arch/x86/mm/ioremap.c
> @@ -341,7 +341,7 @@ void *xlate_dev_mem_ptr(phys_addr_t phys)
>
> addr = (void __force *)ioremap_cache(start, PAGE_SIZE);
> if (addr)
> - addr = (void *)((unsigned long)addr | (phys & ~PAGE_MASK));
> + addr = (void *)((unsigned long)addr | (unsigned long) (phys & ~PAGE_MASK));

What warning did it generate and which compiler version?

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-04-16 12:21    [W:0.083 / U:6.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site