lkml.org 
[lkml]   [2015]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] parport: modify parport subsystem to use devicemodel
On Wed, Apr 15, 2015 at 03:31:15PM +0200, Greg Kroah-Hartman wrote:
> > +
> > +}
>
> empty free functions are a huge red flag. So much so the kobject
> documentation in the kernel says I get to make fun of anyone who tries
> to do this. So please don't do this :)
>
i was just working on the v2 and I saw :
"@release: pointer to the function that will clean up the object when the
last reference to the object is released. This pointer is required, and
it is not acceptable to pass kfree in as this function. If the caller
does pass kfree to this function, you will be publicly mocked mercilessly
by the kref maintainer".

so i thought of checking and it looks like there are a few instances
where kref has been passed as release. :)

regards
sudip
>


\
 
 \ /
  Last update: 2015-04-16 12:21    [W:0.114 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site