lkml.org 
[lkml]   [2015]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] KVM: MMU: fix comment in kvm_mmu_zap_collapsible_spte
On Wed, Apr 15, 2015 at 05:05:48PM +0200, Paolo Bonzini wrote:
>
>
>> - * Only EPT supported for now; otherwise, one would need to
>> - * find out efficiently whether the guest page tables are
>> - * also using huge pages.
>> + * We can not do huge page mapping for the indirect shadow
>> + * page (sp) found on the last rmap (level = 1 ) since
>> + * indirect sp is synced with the page table in guest and
>> + * indirect sp->level = 1 means the guest page table is
>> + * using 4K page size mapping.
>
>What about:
>
>+ * We cannot do huge page mapping for indirect shadow pages,
>+ * which are found on the last rmap (level = 1) when not using
>+ * tdp; such shadow pages are synced with the page table in
>+ * the guest, and the guest page table is using 4K page size
>+ * mapping if the indirect sp has level = 1.

Reviewed-by: Wanpeng Li <wanpeng.li@linux.intel.com>


\
 
 \ /
  Last update: 2015-04-16 11:01    [W:0.077 / U:1.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site