lkml.org 
[lkml]   [2015]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] livepatch: Fix the bug if the function name is larger than KSYM_NAME_LEN-1
On 04/15/15 at 10:30P, Miroslav Benes wrote:
> On Wed, 15 Apr 2015, Minfei Huang wrote:
> >
> > Yes, the function name can be changed, before the extra module is
> > installed to the production system.
> >
> > We discuss around and around, there are still some confusion with it.
> >
> > 1) How does end user know that livepatch can _not_ support the function
> > which length is larger than 127. We can not enforce the end user
> > to know the livepatch and kallsyms code in detail.
> > 2) How does end user use livepatch to patch running extra module, once
> > the module is running in the production system, if the function name
> > is insane.
> > 3) The error message is ambiguity, if we try to patch the overlength
> > function. We can give the error message clearly, once the function
> > name is overlength.
> >
> > I think it is better that we can take more time on the people who will
> > use livepatch frequently.
>
> Just my two cents, even if we admit that such change is worth it (and I
> am still not convinced that it is the case), I think it would make sense
> to fix it somewhere in kallsyms as Josh proposed. I suspect that when
> function names longer than KSYM_NAME_LEN were common there would be many
> similar problems elsewhere in the kernel.
>
> That is you can prepare a patch to kallsyms and submit it there. Not sure
> who is the maintainer but he might have an opinion about this...
>
> Thanks,
> Miroslav

Thanks all who help to review these patches.

I will not insist on it, since it may be encountered rarely.

Thanks
Minfei


\
 
 \ /
  Last update: 2015-04-15 11:21    [W:0.087 / U:6.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site