lkml.org 
[lkml]   [2015]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/7] modpost: handle relocations mismatch in __ex_table.
On Wed, Apr 15, 2015 at 12:57:37PM +0930, Rusty Russell wrote:
>
> I've applied his patch, then the following:

Thanks.

>
> modpost: handle -ffunction-sections
>
> 52dc0595d540 introduced OTHER_TEXT_SECTIONS for identifying what
> sections could validly have __ex_table entries. Unfortunately, it
> wasn't tested with -ffunction-sections, which some architectures
> use.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Cc: Quentin Casasnovas <quentin.casasnovas@oracle.com>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index cbd53e08769d..22dbc604cdb9 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -876,7 +876,7 @@ static void check_section(const char *modname, struct elf_info *elf,
> #define TEXT_SECTIONS ".text", ".text.unlikely", ".sched.text", \
> ".kprobes.text"
> #define OTHER_TEXT_SECTIONS ".ref.text", ".head.text", ".spinlock.text", \
> - ".fixup", ".entry.text"
> + ".fixup", ".entry.text", ".exception.text", ".text.*"
>

Is there a reason we're not adding ".text.*" to TEXT_SECTIONS as opposed to
OTHER_TEXT_SECTIONS? AFAIU, we'll not run the other modpost mismatch
checks when the kernel is compiled with -ffunction-sections otherwise.

I'll send a tentative fix for the divide-by-zero error shortly, sorry about
the mess.

Quentin


\
 
 \ /
  Last update: 2015-04-15 11:01    [W:0.171 / U:3.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site