lkml.org 
[lkml]   [2015]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] KVM: MMU: fix comment in kvm_mmu_zap_collapsible_spte


On 04/15/2015 11:05 PM, Paolo Bonzini wrote:
>
>
>> - * Only EPT supported for now; otherwise, one would need to
>> - * find out efficiently whether the guest page tables are
>> - * also using huge pages.
>> + * We can not do huge page mapping for the indirect shadow
>> + * page (sp) found on the last rmap (level = 1 ) since
>> + * indirect sp is synced with the page table in guest and
>> + * indirect sp->level = 1 means the guest page table is
>> + * using 4K page size mapping.
>
> What about:
>
> + * We cannot do huge page mapping for indirect shadow pages,
> + * which are found on the last rmap (level = 1) when not using
> + * tdp; such shadow pages are synced with the page table in
> + * the guest, and the guest page table is using 4K page size
> + * mapping if the indirect sp has level = 1.

Yeah, much better. Thanks for your improvement, Paolo!


\
 
 \ /
  Last update: 2015-04-16 03:21    [W:0.063 / U:4.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site